-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Use common.expectsError in tests #17484
Conversation
Hi @mithunsasidharan — thank you for contributing. Could you use the checklist in your PR to indicate which changes have happened or whether you've run the tests locally? It seems like all your PRs have the checkboxes completely unchecked. In general, it's helpful to at least run |
@apapirovski : Sorry for missing out on that. I usually run all test for any changes I make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating the checklist 👍
CI: https://ci.nodejs.org/job/node-test-pull-request/11985/ CI was a little wonky the last time, just running again to be safe. |
Landed in d8c896c |
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]>
Refactored tests to replace
assert.throws(fn, common.expectsError(err))
; withcommon.expectsError(fn, err);
in following test files :Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test