Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace function with arrow function #17345

Closed
wants to merge 5 commits into from
Closed

test: replace function with arrow function #17345

wants to merge 5 commits into from
+40 −40

Commits on Nov 27, 2017

  1. test: replace function with arrow function 

    Among the list of [Code and Learn](nodejs/code-and-learn#72 (comment)), I solved the unfinished task of replacing function with arrow function
    @Leko
    Leko committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    79d1fbc View commit details
    Browse the repository at this point in the history

  2. test: replace arrow function with shorter property syntax 

    Arrow function makes `this` lexical scope.
But toString expects evaluate `this` in runtime.
    @Leko
    Leko committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    c0e7ee8 View commit details
    Browse the repository at this point in the history

  3. test: revert changes in test-whatwg-url-searchparams-getall 

    These tests are copied from WPT.
I should not changed it directly.
    @Leko
    Leko committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    6dccb02 View commit details
    Browse the repository at this point in the history

  4. test: replace this with null 

    makeBlock does not need `this`.
update `this` with `null` to clarify the intent.
    @Leko
    Leko committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    0739723 View commit details
    Browse the repository at this point in the history

  5. test: revert to normal function 

    `function() {}` and `() => {}` are should be tested both.
See also #17345 (comment)
    @Leko
    Leko committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    fa4eb72 View commit details
    Browse the repository at this point in the history