Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update HTTP -> HTTPS in CONTRIBUTING.md #17261

Closed
wants to merge 1 commit into from
Closed

doc: Update HTTP -> HTTPS in CONTRIBUTING.md #17261

wants to merge 1 commit into from

Conversation

him2him2
Copy link
Contributor

@him2him2 him2him2 commented Nov 22, 2017 •
edited
Loading

URLs were updated to use HTTPS protocol in CONTRIBUTING.md

Checklist
Affected core subsystem(s)

docs

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: can you please include the subsystem in the commit message and
doc: Update HTTP -> HTTPS in...

Shouldn't have to wait 48 hours

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 23, 2017
@him2him2
doc: Update HTTP -> HTTPs in CONTRIBUTING.md
97e315a 
URLs were updated to use HTTPS protocol in CONTRIBUTING.md
@him2him2 him2him2 changed the title Update HTTP -> HTTPS in CONTRIBUTING.md doc: Update HTTP -> HTTPS in CONTRIBUTING.md Nov 23, 2017
apapirovski pushed a commit that referenced this pull request Nov 23, 2017
@him2him2 @apapirovski
doc: update http URLs to https in CONTRIBUTING.md
de3bb8f 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@apapirovski
Copy link
Member

Landed in de3bb8f

Congrats @him2him2 on becoming a Contributor! 🥇

@him2him2 him2him2 deleted the _fix_CONTRIBUTING.md_HTTPS branch November 24, 2017 06:15
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@him2him2 @MylesBorins
doc: update http URLs to https in CONTRIBUTING.md
d06eae8 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@him2him2 @MylesBorins
doc: update http URLs to https in CONTRIBUTING.md
f3c5f76 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@him2him2 @gibfahn
doc: update http URLs to https in CONTRIBUTING.md
d692f45 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@him2him2 @gibfahn
doc: update http URLs to https in CONTRIBUTING.md
1ffa2f6 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@him2him2 @gibfahn
doc: update http URLs to https in CONTRIBUTING.md
5fe370c 
PR-URL: #17261
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@him2him2 @apapirovski @jasnell @MylesBorins @Trott @lpinca @gibfahn @nodejs-github-bot