Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused variable #17150

Closed
wants to merge 1 commit into from
Closed

src: remove unused variable #17150

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 20, 2017

This fixes a compiler warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@cjihrig
src: remove unused variable
d2f4080 
This fixes a compiler warning.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2017
mhdawson
mhdawson approved these changes Nov 20, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/14172/

I think this is trivial enough to not have to wait 48 hours.

@addaleax
Copy link
Member

Landed in 5df0b9e

@addaleax addaleax closed this Nov 21, 2017
addaleax pushed a commit that referenced this pull request Nov 21, 2017
@cjihrig @addaleax
src: remove unused variable
5df0b9e 
This fixes a compiler warning.

PR-URL: #17150
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig deleted the unused-var branch November 21, 2017 13:34
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@cjihrig @MylesBorins
src: remove unused variable
a9be7bf 
This fixes a compiler warning.

PR-URL: #17150
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @addaleax @apapirovski @jasnell @TimothyGu @tniessen @mhdawson @MylesBorins @gibfahn @nodejs-github-bot