Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: delete unused definition in README.md #17108

Closed
wants to merge 1 commit into from
Closed

doc: delete unused definition in README.md #17108

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, meta

Please, fast track, as it fails linter CI

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 17, 2017
@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. labels Nov 17, 2017
@vsemozhetbyt
Copy link
Contributor Author

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 fast-track

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Nov 17, 2017

Do we have to wait for the complete CI or do node-test-linter and node-test-commit-linuxone suffice?

@refack
Copy link
Contributor

refack commented Nov 17, 2017

IMHO linter is enough, as this obviously does not touch code.

@vsemozhetbyt
Copy link
Contributor Author

Landed in ca3f9b7
Thanks!

vsemozhetbyt added a commit that referenced this pull request Nov 17, 2017
PR-URL: #17108
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@vsemozhetbyt vsemozhetbyt deleted the doc-del-unused-definition branch November 17, 2017 22:58
@vsemozhetbyt vsemozhetbyt mentioned this pull request Nov 17, 2017
3 tasks
@Trott
Copy link
Member

Trott commented Nov 17, 2017

🎉 Thanks!

MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17108
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17108
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17108
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17108
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants