doc: document fs.realpath.native() #17059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Nov 15, 2017
evanlucas
approved these changes
Nov 15, 2017
refack
approved these changes
Nov 15, 2017
cjihrig
approved these changes
Nov 15, 2017
lpinca
approved these changes
Nov 16, 2017
Mea culpa, somehow I managed to drop the documentation commit while merging the pull request. This should have been included in commit 74023c0 ("fs: expose realpath(3) bindings") from this month. PR-URL: nodejs#17059 Refs: nodejs#15776 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
bnoordhuis
force-pushed
the
realpath-docs
branch
from
b1d6990
to
cb137eb
Compare
|
Landed in cb137eb. I didn't wait 48 hours because it also had sign-offs in the old PR. Thanks everyone. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
Mea culpa, somehow I managed to drop the documentation commit while merging the pull request. This should have been included in commit 74023c0 ("fs: expose realpath(3) bindings") from this month. PR-URL: #17059 Refs: #15776 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
|
Should be backported with #15776 in a semver-minor. |
MylesBorins
added
baking-for-lts
3 tasks
MylesBorins
added
dont-land-on-v8.x
and removed
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mea culpa, somehow I managed to drop the documentation commit while
merging the pull request. This should have been included in commit
74023c0 ("fs: expose realpath(3) bindings") from this month.
Refs: #15776