-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: concatenated stirng to template string #16930
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Nov 10, 2017
tniessen
approved these changes
Nov 10, 2017
jasnell
approved these changes
Nov 10, 2017
fhinkel
approved these changes
Nov 11, 2017
fhinkel
pushed a commit
that referenced
this pull request
Nov 11, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
I've opted to not land this on v6.x as I am unsure if interpolated strings are optimized with that version of V8 |
Merged
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
dns
Issues and PRs related to the dns subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
When I ran the test got the following error message, looks like unrelated to the PR
Submitting my first PR for node.js, please have a look