Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add hashseed to collaborators #16863

Closed
wants to merge 1 commit into from
Closed

doc: add hashseed to collaborators #16863

wants to merge 1 commit into from

Conversation

hashseed
Copy link
Member

@hashseed hashseed commented Nov 7, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

PR-URL: #16863

@hashseed hashseed requested a review from Trott November 7, 2017 14:16
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2017
@hashseed
Copy link
Member Author

hashseed commented Nov 7, 2017

CI job: https://ci.nodejs.org/job/node-test-pull-request/11269/

targos
targos approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

hashseed added a commit that referenced this pull request Nov 7, 2017
@hashseed
doc: add hashseed to collaborators
3d7f0fe 
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@hashseed
Copy link
Member Author

hashseed commented Nov 7, 2017

Landed in 3d7f0fe

@hashseed hashseed closed this Nov 7, 2017
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 11, 2017
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
@hashseed @MylesBorins
doc: add hashseed to collaborators
7594032 
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@hashseed @MylesBorins
doc: add hashseed to collaborators
0f94bb9 
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@hashseed @gibfahn
doc: add hashseed to collaborators
d07403d 
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@hashseed @gibfahn
doc: add hashseed to collaborators
996108c 
PR-URL: #16863
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@hashseed hashseed deleted the hashseed-doc branch January 11, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hashseed @danbev @Trott @addaleax @targos @cjihrig @gireeshpunathil @vsemozhetbyt @gibfahn @nodejs-github-bot