Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: test search module #16795

Closed
wants to merge 1 commit into from
Closed

Conversation

clakech
Copy link
Contributor

@clakech clakech commented Nov 6, 2017

Checklist
  • make -j4 test (UNIX)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@mscdex mscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 6, 2017
@joyeecheung
Copy link
Member

1 similar comment
@joyeecheung
Copy link
Member

@clakech
Copy link
Contributor Author

clakech commented Nov 7, 2017

@joyeecheung Hi, thanks for running the CI. The build is stuck since 5 hours. What should I do ?

@Trott
Copy link
Member

Trott commented Nov 7, 2017

The build is stuck since 5 hours. What should I do ?

@clakech All the CI runs are done except an AIX host which only became available for this CI run about 10 minutes ago. Everything else passed, so I'm pretty sure the AIX host will pass too.

@Trott
Copy link
Member

Trott commented Nov 7, 2017

I'm pretty sure the AIX host will pass too.

As my father used to say: "Famous last words..."

AIX failed, but it's unrelated. I opened an issue about the failure at #16859. Meanwhile, this can land.

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Meanwhile, this can land.

Er, well, it should stay up for another day or two before landing. But I mean, Ci is OK. (Of course if any changes are requested and made, we'll need to re-run CI.)

@clakech
Copy link
Contributor Author

clakech commented Nov 10, 2017

hi @Trott, should we launch another CI build ? or it could land as is ?

@joyeecheung
Copy link
Member

jasnell pushed a commit that referenced this pull request Nov 12, 2017
PR-URL: #16795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 12, 2017

Landed in e0113ab

@jasnell jasnell closed this Nov 12, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
PR-URL: #16795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
PR-URL: #16795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.