build: Allow linking against an external copy of nghttp2. #16788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
Oh, wait. It looks as if this is a duplicate of #15256. That said, that pull request has been stuck for more than a month. |
|
@EdSchouten Don’t worry about this being a duplicate – the other PR hasn’t seen movement in a long time, so it’s actually nice to have somebody pick it up. Either way, this appear to need a rebase? |
addaleax
approved these changes
Nov 18, 2017
The version of nghttp2 in deps/ does not build on CloudABI, even though the official version does. Though this is an issue on its own that needs to be resolved, it is currently a bit hard to work around this. There is no switch to link against an external version of nghttp2, even though we do provide this option for other libraries. This change adds configure flags, similar to the ones we have for OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on deps/nghttp2 optional.
|
Perfect! I've just rebased these changes. |
bnoordhuis
approved these changes
Nov 20, 2017
| @@ -186,8 +186,7 @@ | |||
| 'include_dirs': [ | |||
| 'src', | |||
| 'tools/msvs/genfiles', | |||
| '<(SHARED_INTERMEDIATE_DIR)', # for node_natives.h | |||
| 'deps/nghttp2/lib/includes' | |||
| '<(SHARED_INTERMEDIATE_DIR)' # for node_natives.h | |||
There was a problem hiding this comment.
Can you keep the comma? Makes the diff less noisy (also when a line is added later.)
| ], | ||
| 'include_dirs': [ | ||
| 'deps/nghttp2/lib/includes' | ||
| ] |
There was a problem hiding this comment.
The include_dirs is probably not necessary, nghttp2.gyp also exports it through direct_dependent_settings.
refack
approved these changes
Nov 20, 2017
|
Landed in 336af9a. |
refack
pushed a commit
that referenced
this pull request
Nov 20, 2017
The version of nghttp2 in deps/ does not build on CloudABI, even though the official version does. Though this is an issue on its own that needs to be resolved, it is currently a bit hard to work around this. There is no switch to link against an external version of nghttp2, even though we do provide this option for other libraries. This change adds configure flags, similar to the ones we have for OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on deps/nghttp2 optional. PR-URL: #16788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
The version of nghttp2 in deps/ does not build on CloudABI, even though the official version does. Though this is an issue on its own that needs to be resolved, it is currently a bit hard to work around this. There is no switch to link against an external version of nghttp2, even though we do provide this option for other libraries. This change adds configure flags, similar to the ones we have for OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on deps/nghttp2 optional. PR-URL: #16788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
The version of nghttp2 in deps/ does not build on CloudABI, even though the official version does. Though this is an issue on its own that needs to be resolved, it is currently a bit hard to work around this. There is no switch to link against an external version of nghttp2, even though we do provide this option for other libraries. This change adds configure flags, similar to the ones we have for OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on deps/nghttp2 optional. PR-URL: #16788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
The version of nghttp2 in deps/ does not build on CloudABI, even though the official version does. Though this is an issue on its own that needs to be resolved, it is currently a bit hard to work around this. There is no switch to link against an external version of nghttp2, even though we do provide this option for other libraries. This change adds configure flags, similar to the ones we have for OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on deps/nghttp2 optional. PR-URL: #16788 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of nghttp2 in deps/ does not build on CloudABI, even though
the official version does. Though this is an issue on its own that needs
to be resolved, it is currently a bit hard to work around this. There is
no switch to link against an external version of nghttp2, even though we
do provide this option for other libraries.
This change adds configure flags, similar to the ones we have for
OpenSSL, zlib, http_parser, libuv, etc. and makes the dependency on
deps/nghttp2 optional.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)