Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.9.1 proposal #16783

Merged
merged 15 commits into from
Nov 7, 2017
Merged

v8.9.1 proposal #16783

merged 15 commits into from
Nov 7, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Nov 5, 2017

2017-11-07, Version 8.9.1 'Carbon' (LTS), @gibfahn

Notable Changes

Commits

rvagg and others added 12 commits November 2, 2017 09:28
This makes the process.release.lts property configurable by a constant.

This ref is the original PR to v6.x.
Refs: #3212

 Conflicts:
        doc/api/process.md

PR-URL: #16656
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
PR-URL: #16656
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
This replaces all sources of openssl-1.0.2m.tar.gz into
deps/openssl/openssl

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
All symlink files in `deps/openssl/openssl/include/openssl/`
are removed and replaced with real header files to avoid
issues on Windows. Two files of opensslconf.h in crypto and
include dir are replaced to refer config/opensslconf.h.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reapply b910613 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This reverts commit 5118f31.

It is breaking code in the wild that depends on the original behavior
to do tracing.

I don't think we need to necessarily fix this in 8.x but we might want
to reclassify the original commit as Semver Major

PR-URL: #16660
Refs: #16395
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Jan Krems <[email protected]>
PR-URL: #16672
Fixes: https://github.com/node/issues/16671
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Original commit message:
    tty, win: get SetWinEventHook pointer at startup

    SetWinEventHook is not available on some Windows versions.

    Fixes: #16603
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: #16724
Fixes: #16603
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency. v8.x labels Nov 5, 2017
gibfahn added a commit that referenced this pull request Nov 5, 2017
@richardlau
Copy link
Member

Shouldn't the openssl notable change be the update to 1.0.2m?

@MylesBorins
Copy link
Contributor

+1 to the updated notable change for openssl... the keypress fix is a refloat afaik

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 6, 2017

might want to bring in 3a977fc to fix the flake on windows

Kicking off CI one more time: https://ci.nodejs.org/job/node-test-pull-request/11203/

@gibfahn
Copy link
Member Author

gibfahn commented Nov 6, 2017

Shouldn't the openssl notable change be the update to 1.0.2m?

Hah, yes, copy&paste error.

EDIT: Fixed

Original commit message:
  Disable --turbo-inline-array-builtins by default.

  Current chrome stable has a high number of crashes due to bugs in
  this feature. These bugs are already fixed but the fixes are hard
  to merge back. Therefore we decided to disable the feature in stable.
  This CL is intended to be merged to stable and then reverted in tot.

  Bug: chromium:762020
  Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b
  Reviewed-on: https://chromium-review.googlesource.com/738176
  Reviewed-by: Jaroslav Sevcik <[email protected]>
  Commit-Queue: Georg Neis <[email protected]>
  Cr-Commit-Position: refs/heads/master@{#48931}

Refs: v8/v8@32141e9
PR-URL: #16704
@gibfahn
Copy link
Member Author

gibfahn commented Nov 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11273/
CI 2: https://ci.nodejs.org/job/node-test-pull-request/11281/
CitGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1066/

Release: https://ci-release.nodejs.org/job/iojs+release/2222/

Test Failures:

  • parallel/test-http2-server-rst-stream on smartos16
Test output
not ok 950 parallel/test-http2-server-rst-stream
  ---
  duration_ms: 0.829
  severity: fail
  stack: |-
    (node:31144) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: rstWithInternalError is not match rstCode
        at ClientHttp2Stream.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/parallel/test-http2-server-rst-stream.js:55:14)
        at ClientHttp2Stream.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/common/index.js:533:15)
        at emitOne (events.js:121:20)
        at ClientHttp2Stream.emit (events.js:211:7)
        at emit (internal/http2/core.js:140:8)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
  ...

CitGM Failures:

  • Sodium Native v2.0.0 - didn't fail in previous release ([email protected])
  • citgm.ava-v0.23.0 (also failing in 6.12.0)
  • citgm.coffeescript-v2.0.2 citgm.esprima-v4.0.0 citgm.lodash-v4.17.4 citgm.sax-v1.2.4 citgm.semver-v5.4.1 citgm.thread-sleep-v2.0.0 citgm.watchify-v3.9.0 all failing on AIX or Windows with permissions errors.

Notable Changes:

- **openssl**:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691)
- ***Revert*** "**https**:
  - refactor to use http internals" (Myles Borins) [#16660](#16660)

PR-URL: #16783
@gibfahn gibfahn merged commit edb03cb into v8.x Nov 7, 2017
gibfahn added a commit that referenced this pull request Nov 7, 2017
Notable Changes:

- **openssl**:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691)
- ***Revert*** "**https**:
  - refactor to use http internals" (Myles Borins) [#16660](#16660)

PR-URL: #16783
@gibfahn gibfahn deleted the v8.9.1-proposal branch November 7, 2017 22:49
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants