src: CHECK() for argument overflow in Spawn() #16761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
gireeshpunathil
approved these changes
Nov 5, 2017
|
If a program requires 2^31 number of arguments for its function, either it should be uimaginably complex, or buggy. In either case this check is great to have! |
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: nodejs#15622 PR-URL: nodejs#16761 Reviewed-By: Gireesh Punathil <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: #15622 PR-URL: #16761 Reviewed-By: Gireesh Punathil <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: #15622 PR-URL: #16761 Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: #15622 PR-URL: #16761 Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: #15622 PR-URL: #16761 Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: #15622 PR-URL: #16761 Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds checks for overflow of
argsandenvinSpawn(). It seems extremely unlikely that either of these values would overflow from a valid use case.Fixes: #15622
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src