-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: correctly handle relative unix socket paths #16749
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const cluster = require('cluster'); | ||
const net = require('net'); | ||
const path = require('path'); | ||
const fs = require('fs'); | ||
|
||
// Ref: | ||
// https://github.com/nodejs/node/issues/16387 | ||
// https://github.com/nodejs/node/pull/16749 | ||
|
||
if (common.isWindows) | ||
common.skip('On Windows named pipes live in their own ' + | ||
'filesystem and don\'t have a ~100 byte limit'); | ||
|
||
// Choose a socket name such that the absolute path would exceed 100 bytes. | ||
const socketDir = './unix-socket-dir'; | ||
const socketName = 'A'.repeat(100 - socketDir.length - 1); | ||
|
||
// Make sure we're not in a weird environment | ||
assert.strictEqual(path.resolve(socketDir, socketName).length > 100, true, | ||
'absolute socket path should be longer than 100 bytes'); | ||
|
||
if (cluster.isMaster) { | ||
// ensure that the worker exits peacefully | ||
process.chdir(common.tmpDir); | ||
fs.mkdirSync(socketDir); | ||
cluster.fork().on('exit', common.mustCall(function(statusCode) { | ||
assert.strictEqual(statusCode, 0); | ||
|
||
assert.strictEqual( | ||
fs.existsSync(path.join(socketDir, socketName)), false, | ||
'Socket should be removed when the worker exits'); | ||
})); | ||
} else { | ||
process.chdir(socketDir); | ||
|
||
const server = net.createServer(common.mustNotCall()); | ||
|
||
server.listen(socketName, common.mustCall(function() { | ||
assert.strictEqual( | ||
fs.existsSync(socketName), true, | ||
'Socket created in CWD'); | ||
|
||
process.disconnect(); | ||
})); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These refs can be removed during landing. They should be in the metadata, not in the comments.