build: add missing comma in sources list #16613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
gireeshpunathil
approved these changes
Oct 30, 2017
|
I wonder how it was building / working so far with this issue! |
richardlau
approved these changes
Oct 30, 2017
cjihrig
approved these changes
Oct 30, 2017
JungMinu
approved these changes
Oct 30, 2017
gibfahn
approved these changes
Oct 30, 2017
joyeecheung
approved these changes
Oct 30, 2017
daxlab
approved these changes
Oct 30, 2017
apapirovski
approved these changes
Oct 30, 2017
|
Triggering another CI to double check Windows failure: https://ci.nodejs.org/job/node-test-pull-request/11125/ |
danbev
force-pushed
the
build-missing-comma-sources
branch
from
4688584
to
3ca202f
Compare
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h
test/arm-fanned failure looks unrelatedwarning: failed to remove out/
Removing out/
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILUREtest/windows-fanned failure looks unrelatedResetting working tree
> git reset --hard # timeout=10
> git clean -fdx # timeout=10
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins4777955810906737101.bat
c:\workspace\node-test-binary-windows>echo off
Wed 11/01/2017 4:03:40.35
c:\workspace\node-test-binary-windows>tasklist | grep node || true
c:\workspace\node-test-binary-windows>exit 0
[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins2702603836202563709.bat
c:\workspace\node-test-binary-windows>TASKKILL /F /IM node.exe /T || TRUE
ERROR: The process "node.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM cctest.exe /T || TRUE
ERROR: The process "cctest.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM run-tests.exe /T || TRUE
ERROR: The process "run-tests.exe" not found.
c:\workspace\node-test-binary-windows>TASKKILL /F /IM yes.exe /T || TRUE
ERROR: The process "yes.exe" not found.
c:\workspace\node-test-binary-windows>git checkout -f refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013
error: pathspec 'refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013' did not match any file(s) known to git.
c:\workspace\node-test-binary-windows>if 1 NEQ 0 exit /b 1
Build step 'Execute Windows batch command' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE |
|
Landed in 18df171 |
danbev
added a commit
that referenced
this pull request
Nov 1, 2017
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: #16613 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs/node#16613 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs#16613 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Since these are |
gibfahn
pushed a commit
that referenced
this pull request
Nov 14, 2017
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: #16613 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This commit adds a missing comma in the sources list. This effects at least window which produces the following warning where trace_event.h and src/util.h are concatenated: Warning: Missing input files: src\tracing\trace_event.hsrc\util.h PR-URL: nodejs/node#16613 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build