test: allow for different nsswitch.conf settings #16378

danbev · 2017-10-22T10:14:50Z

The motivation for this commit is that these two test fail on systems
that have different Name Service Switch configuration settings. A
concrete example of this is when using Red Hat Enterprise Linux (RHEL)
7.

If Name Service Switch is available on the operating system then it
might be configured differently (/etc/nsswitch.conf).
If the system is configured with no dns the error code will be
AI_AGAIN, but if there are more services after the dns entry, for
example some linux distributions skip a myhostname service by default
which would still produce the ENOTFOUND error.

This commit suggests checking for either ENOTFOUND or EAI_AGAIN to
accommodate systems like the ones described above. The references below
indicate that others have run, or are running, into this aswell.

Refs: #12075
Refs: nodejs/help#687

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

test

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: nodejs#12075 Refs: nodejs/help#687

bnoordhuis

It sounds like this might fix #15825 if also applied to parallel/test-{https,tls}-connect-address-family.

danbev · 2017-10-22T13:43:25Z

It sounds like this might fix #15825 if also applied to parallel/test-{https,tls}-connect-address-family.

I'll take a closer look at them tomorrow.

The hosts configuration on a system can affect how dns look up works and different error can occur with different setups. This commit adds a check for EAI_AGAIN to avoid the issue reported in the issue referred to below. Refs: nodejs#15825

danbev · 2017-10-24T12:17:16Z

It sounds like this might fix #15825 if also applied to parallel/test-{https,tls}-connect-address-family.

I was able to reproduce these and added this commit. I've not marked it as squash but I'm happy to have it squashed if that is alright and just include the ref in the final commit. Thanks!

bnoordhuis

happy to have it squashed if that is alright and just include the ref in the final commit.

LGTM and SGTM!

danbev · 2017-10-25T05:29:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10953/

danbev · 2017-10-25T07:07:34Z

test/arm-fanned failure looks unrelated

console output:

real	0m22.219s
user	0m2.330s
sys	0m5.800s
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-11977-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmp
From file:///home/iojs/.ccache/node.shared.reference
 + c11d5a9...be3e18b jenkins-node-test-commit-arm-fanned-11977-binary-pi1p/cc-armv6 -> jenkins_tmp  (forced update)

real	0m51.195s
user	0m19.150s
sys	0m8.280s
+ rm -f ****
+ git checkout -f refs/remotes/jenkins_tmp
Warning: you are leaving 2 commits behind, not connected to
any of your branches:

  c11d5a9 added binaries
  846a46f doc: fix missing newline character

If you want to keep them by creating a new branch, this may be a good time
to do so with:

 git branch <new-branch-name> c11d5a9

HEAD is now at be3e18b... added binaries

real	0m33.234s
user	0m3.050s
sys	0m18.670s
+ git reset --hard
HEAD is now at be3e18b added binaries

real	0m11.115s
user	0m3.410s
sys	0m2.900s
+ git clean -fdx
warning: failed to remove out/Release/.nfs00000000000f537d000002f9
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: nodejs#12075 Refs: nodejs/help#687 Refs: nodejs#15825 PR-URL: nodejs#16378 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

danbev · 2017-10-25T09:18:56Z

Landed in 50d7275

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: #12075 Refs: nodejs/help#687 Refs: #15825 PR-URL: #16378 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: nodejs/node#12075 Refs: nodejs/help#687 Refs: nodejs/node#15825 PR-URL: nodejs/node#16378 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: #12075 Refs: nodejs/help#687 Refs: #15825 PR-URL: #16378 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: nodejs/node#12075 Refs: nodejs/help#687 Refs: nodejs/node#15825 PR-URL: nodejs/node#16378 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 22, 2017

addaleax approved these changes Oct 22, 2017

View reviewed changes

addaleax added the dns Issues and PRs related to the dns subsystem. label Oct 22, 2017

bnoordhuis approved these changes Oct 22, 2017

View reviewed changes

jasnell approved these changes Oct 22, 2017

View reviewed changes

lpinca approved these changes Oct 23, 2017

View reviewed changes

cjihrig approved these changes Oct 23, 2017

View reviewed changes

test: allow for differences in hosts config

4c61f48

The hosts configuration on a system can affect how dns look up works and different error can occur with different setups. This commit adds a check for EAI_AGAIN to avoid the issue reported in the issue referred to below. Refs: nodejs#15825

bnoordhuis approved these changes Oct 24, 2017

View reviewed changes

danbev closed this Oct 25, 2017

danbev deleted the nsswitch branch October 25, 2017 09:19

cjihrig mentioned this pull request Oct 25, 2017

v8.8.1 proposal #16498

Merged

MylesBorins added the land-on-v6.x label Nov 16, 2017

MylesBorins mentioned this pull request Nov 21, 2017

v6.12.1 proposal #17180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: allow for different nsswitch.conf settings #16378

test: allow for different nsswitch.conf settings #16378

danbev commented Oct 22, 2017

bnoordhuis left a comment

danbev commented Oct 22, 2017

danbev commented Oct 24, 2017

bnoordhuis left a comment

danbev commented Oct 25, 2017

danbev commented Oct 25, 2017

danbev commented Oct 25, 2017

test: allow for different nsswitch.conf settings #16378

test: allow for different nsswitch.conf settings #16378

Conversation

danbev commented Oct 22, 2017

Checklist

Affected core subsystem(s)

bnoordhuis left a comment

Choose a reason for hiding this comment

danbev commented Oct 22, 2017

danbev commented Oct 24, 2017

bnoordhuis left a comment

Choose a reason for hiding this comment

danbev commented Oct 25, 2017

danbev commented Oct 25, 2017

danbev commented Oct 25, 2017