doc: fix paragraph line-height issue #16200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a line-height issue introduced in nodejs#15660 where paragraphs containing <code> blocks would have unequal line heights. Fixes: nodejs/nodejs.org#1399
gireeshpunathil
approved these changes
Oct 14, 2017
lpinca
approved these changes
Oct 14, 2017
hiroppy
approved these changes
Oct 14, 2017
vsemozhetbyt
approved these changes
Oct 14, 2017
tniessen
approved these changes
Oct 14, 2017
|
Thanks, landed in 4247913. |
silverwind
added a commit
that referenced
this pull request
Oct 15, 2017
Fix a line-height issue introduced in #15660 where paragraphs containing <code> blocks would have unequal line heights. Fixes: nodejs/nodejs.org#1399 PR-URL: #16200 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Fix a line-height issue introduced in #15660 where paragraphs containing <code> blocks would have unequal line heights. Fixes: nodejs/nodejs.org#1399 PR-URL: nodejs/node#16200 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Fix a line-height issue introduced in #15660 where paragraphs containing <code> blocks would have unequal line heights. Fixes: nodejs/nodejs.org#1399 PR-URL: #16200 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc
Fix a line-height issue introduced in #15660 where paragraphs containing
<code>blocks would have unequal line heights.Fixes: nodejs/nodejs.org#1399
Before
After