Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move 8 collaborators to emeriti #16173

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 13, 2017

As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

Checklist
Affected core subsystem(s)

doc

As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 13, 2017
Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott - are there any guidance on the duration of inactivity period?

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this could be automated later by specifying a number of days after which a collaborator is marked as inactive. Probably should also think about removing commit access at some point in time.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2017

@Trott - are there any guidance on the duration of inactivity period?

@gireeshpunathil None that are documented. If I recall correctly, I checked for people with zero commits since the release of Node.js 4.0.0 in September 2015, so that's over 2 years ago.

I think this could be automated

@silverwind Perhaps the initial auditing could be automated like that, and that would be very helpful. We'll probably always want some level of manual review. It's possible someone doesn't have any commits in a while, but is still landing PRs from other contributors, or participating in private repos on security issues, or kicking off CI jobs for people, or triaging via labeling issues and closing stalled/resolved issues, or any number of other things that require some elevated privileges but that might be more challenging to audit for automatically. (I'm sure some of the things I mentioned are easy to audit for automatically, but I'm also sure that not all of them are. And it's not a comprehensive list.)

Probably should also think about removing commit access at some point in time.

@silverwind Already done for these eight folks. Thanks for mentioning it, though. I should have said so in the initial PR description.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

@Trott is this followed up by removing permissions? Do we have the process documented?

@Trott
Copy link
Member Author

Trott commented Oct 13, 2017

@Trott is this followed up by removing permissions?

Only thing I did was remove them from the Collaborators team. That seems to mirror what we do at onboarding pretty well. Oh, also for a few of them who were now only in the members team, I removed them from that too, but I wasn't meticulous about that. Auditing members team is a bigger and more challenging problem, perhaps because sometimes it's totally legitimate to only be in the members team.

Do we have the process documented?

Nope. I'll PR in a doc. Probably should go in this repo next to the onboarding doc. Might be good, though, for someone to start thinking about if/how/when to audit the members team and PR something about that into the admin repo.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2017

Addendum: If they were on 0 teams but still in the org, I removed them from the org.

@Trott
Copy link
Member Author

Trott commented Oct 13, 2017

(Also, just in case it's not widely known: Removing from the Collaborators team means they don't have a commit bit on this repo, they can't start CI jobs, and they can't add/remove labels here.)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Oct 13, 2017
As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

PR-URL: nodejs#16173
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 13, 2017

Landed in 4db8472.

@Trott Trott closed this Oct 13, 2017
targos pushed a commit that referenced this pull request Oct 18, 2017
As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

PR-URL: #16173
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

PR-URL: #16173
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

PR-URL: #16173
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
As discussed in TSC email, I contacted 8 Collaborators whose last
activity appears to be quite some time ago to suggest that they be moved
to emeritus status until such a time as they will be active again. There
were no objections from the 8 Collaborators or the TSC.

PR-URL: #16173
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@Trott Trott deleted the collab-emeriti branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.