Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: remove unused err argument #16152

Closed
wants to merge 1 commit into from
Closed

repl: remove unused err argument #16152

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Not used by any callers in lib/repl.js, and is not public API.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

@maclover7
repl: remove unused err argument
88b041c 
Not used by any callers in `lib/repl.js`, and is not public API.
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 11, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10633/

@joyeecheung
Copy link
Member

Landed in 0229e67, thanks!

joyeecheung pushed a commit that referenced this pull request Oct 12, 2017
@maclover7 @joyeecheung
repl: remove unused err argument
0229e67 
Not used by any callers in `lib/repl.js`, and is not public API.

PR-URL: #16152
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@maclover7 maclover7 deleted the jm-rm-arg branch October 12, 2017 19:54
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@maclover7 @addaleax
repl: remove unused err argument
c498448 
Not used by any callers in `lib/repl.js`, and is not public API.

PR-URL: nodejs/node#16152
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@maclover7 @targos
repl: remove unused err argument
25ed24f 
Not used by any callers in `lib/repl.js`, and is not public API.

PR-URL: #16152
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@maclover7 @targos
repl: remove unused err argument
1168e01 
Not used by any callers in `lib/repl.js`, and is not public API.

PR-URL: #16152
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Prince John Wesley <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@princejwesley princejwesley princejwesley approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maclover7 @joyeecheung @fhinkel @jasnell @lpinca @princejwesley @cjihrig @MylesBorins @nodejs-github-bot