Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert url perf changes #1602

Merged
merged 3 commits into from
May 4, 2015
Merged

Revert url perf changes #1602

merged 3 commits into from
May 4, 2015

Commits on May 3, 2015

  1. Revert "url: fix treatment of some values as non-empty" 

    This reverts commit 6687721.
    @rvagg
    rvagg committed May 3, 2015
    Configuration menu
    Copy the full SHA
    aa0e1a3 View commit details
    Browse the repository at this point in the history

  2. Revert "url: delete href cache on all setter code paths" 

    This reverts commit dbdd81a.
    @rvagg
    rvagg committed May 3, 2015
    Configuration menu
    Copy the full SHA
    290c0ee View commit details
    Browse the repository at this point in the history

Commits on May 4, 2015

  1. Revert "url: significantly improve the performance of the url module" 

    This reverts commit 3fd7fc4.

It was agreed that this change contained too much potential ecosystem
breakage, particularly around the inability to `delete` properties off a
`Url` object. It may be re-introduced for a later release, along with
better work on ecosystem compatibility.

PR-URL: nodejs#1602
Reviewed-By: Mikeal Rogers <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Forrest L Norvell <[email protected]>
Reviewed-By: Chris Dickinson <[email protected]>
Reviewed-By: Isaac Z. Schlueter <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
    @rvagg
    rvagg committed May 4, 2015
    Configuration menu
    Copy the full SHA
    f34b105 View commit details
    Browse the repository at this point in the history