build: added ignore path for eslint #16010

chrisbudy · 2017-10-06T18:51:14Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

Trott · 2017-10-07T05:01:50Z

.eslintignore is the default, so this change should be a no-op. I think the problem we saw at Code + Learn probably had to do with a problem in the .eslintignore itself?

addaleax

Doesn’t seem to hurt anybody, and if it helps someone, sure

Trott · 2017-10-07T21:24:42Z

Can someone with a Windows machine (preferably @chrisbudy!) do this to confirm that this fixes anything or else confirm that it has no effect?

Create a file called test/tmp/test.js. Make the contents nothing but a garbage string like Fhwqhgads.
Run vcbuild lint-js. Does it show errors? If so, we have a bug. If not, something weird was up at Code + Learn.
Now make the change in this PR. Run vcbuild lint-js. Does it show errors?

If the second step shows errors and the third step does not, then this PR should land. If any other combination occurs, then this PR should not land.

refack · 2017-10-07T21:30:55Z

BTW a better command is vcbuild noprojgen nobuild lint-js

refack · 2017-10-07T22:05:29Z

I can't repro.
Also, trying to force check the canary file gives:

D:\code\node-github-desktop$ node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules test\tmp\test.js

D:\code\node-github-desktop\test\tmp\test.js
  0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to override

✖ 1 problem (0 errors, 1 warning)

I'd also be happy to hear from @chrisbudy that this positively solves the issue.

refack · 2017-10-07T22:11:25Z

@chrisbudy maybe you have a global .eslintrc with a no-ignore rule?

chrisbudy · 2017-10-09T15:39:13Z

@Trott I assumed it should default as well, but I was getting build errors on a tmp file (event though excluded in the .eslintignore file) at the code and learn, and adding the line I did stopped the build errors from happening. But I will test it again today.

Thanks for the feedback @refack and @Trott.

BridgeAR · 2017-10-18T15:39:04Z

@chrisbudy did you get the chance to test this again?

Trott

Someone else tested this and unfortunately this doesn't solve the problem. See details here: #16278 (comment)

Trott · 2017-10-21T20:19:53Z

I'm going to close this one but feel free to re-open or comment if you think this should stay open. The solution is likely a bug-fix in ESLint. Alternatively, we could add a common.refreshTmpDir() to the end of the test that creates the directory with multi-byte characters, but I'd prefer this be run up to ESLint instead, TBH. Will need some Windows folks willing to dig a bit, though. That's not me, unfortunately.

Makes eslint exclude directories without enumerating their content PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>

build: added ignore path for eslint

499f517

nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Oct 6, 2017

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017

addaleax approved these changes Oct 7, 2017

View reviewed changes

refack self-assigned this Oct 7, 2017

jasnell approved these changes Oct 9, 2017

View reviewed changes

Trott requested changes Oct 21, 2017

View reviewed changes

Trott closed this Oct 21, 2017

refack mentioned this pull request Oct 21, 2017

Tweak esignore #16372

Merged

2 tasks

refack removed their assignment Oct 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: added ignore path for eslint #16010

build: added ignore path for eslint #16010

chrisbudy commented Oct 6, 2017 •

edited

Loading

Trott commented Oct 7, 2017

addaleax left a comment

Trott commented Oct 7, 2017

refack commented Oct 7, 2017 •

edited

Loading

refack commented Oct 7, 2017 •

edited

Loading

refack commented Oct 7, 2017

chrisbudy commented Oct 9, 2017

BridgeAR commented Oct 18, 2017

Trott left a comment

Trott commented Oct 21, 2017

build: added ignore path for eslint #16010

build: added ignore path for eslint #16010

Conversation

chrisbudy commented Oct 6, 2017 • edited Loading

Checklist

Affected core subsystem(s)

Trott commented Oct 7, 2017

addaleax left a comment

Choose a reason for hiding this comment

Trott commented Oct 7, 2017

refack commented Oct 7, 2017 • edited Loading

refack commented Oct 7, 2017 • edited Loading

refack commented Oct 7, 2017

chrisbudy commented Oct 9, 2017

BridgeAR commented Oct 18, 2017

Trott left a comment

Choose a reason for hiding this comment

Trott commented Oct 21, 2017

chrisbudy commented Oct 6, 2017 •

edited

Loading

refack commented Oct 7, 2017 •

edited

Loading

refack commented Oct 7, 2017 •

edited

Loading