Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internet: improve assert message #15998

Closed
wants to merge 5 commits into from
Closed

internet: improve assert message #15998

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b2b6cc
internet: improve assert message
Oct 6, 2017
7374adb
Remove all white spaces
Oct 12, 2017
301e7f1
Add one space
Oct 12, 2017
3523ff6
Swap arguments
Oct 16, 2017
68f8786
Removed message
Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/internet/test-dgram-broadcast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ if (process.argv[2] !== 'child') {
assert.strictEqual(
count,
messages.length,
'A worker received an invalid multicast message'
`A worker received an invalid multicast message.
Received ${messages.length} and wanted ${count}.`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message includes extra spaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens because it is a multi line template strings. In this case all spaces in the beginning of the second line are real spaces in the string. In Node.js we limit every string to a single line to prevent things like that. It should therefore either be changed now or while landing.

Copy link
Member

@Trott Trott Oct 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @nikkistonge! Welcome and thanks for doing this. It would be acceptable to use concatenation here:

    'A worker received an invalid multicast message.' +
    `Received ${messages.length} and expected {$count}.`

That would address the comments above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay, didn't see these comments.

I didn't know that was how template strings worked, I've only ever used them for SQL and html stuff and both don't care about extra spaces so I assumed they got removed.

Changed my code to remove them and added just one space after the first sentence. @Trott

);
});

Expand Down