Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test messages for assert.strictEqual #15995

Closed
wants to merge 2 commits into from
Closed

update test messages for assert.strictEqual #15995

wants to merge 2 commits into from

Conversation

tisAliG
Copy link
Contributor

@tisAliG tisAliG commented Oct 6, 2017

Checklist
Affected core subsystem(s)

test-crypto

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@tisAliG tisAliG force-pushed the master branch 2 times, most recently from dcc461e to baf7373 Compare October 6, 2017 18:36
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
BridgeAR
BridgeAR reviewed Oct 6, 2017
View reviewed changes
test/parallel/test-crypto-cipher-decipher.js Outdated
@@ -25,7 +25,7 @@ function testCipher1(key) {
let txt = decipher.update(ciph, 'hex', 'utf8');
txt += decipher.final('utf8');

assert.strictEqual(txt, plaintext, 'encryption and decryption');
assert.strictEqual(txt, plaintext, `${txt} is encrypted, ${plaintext} is unencrypted`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would prefer to just remove the error message overall instead of using the individual ones in all these cases. The reason is that it could theoretically be a different case than the description value (the test should pass and we do not know the real reason why the test would not pass).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @BridgeAR. I think it's better to just remove the custom messages (third argument) here and use the default one.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10706/

@joyeecheung
Copy link
Member

Landed in f4cab35, thank you for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
@tisAliG @joyeecheung
test: remove test messages for assert.strictEqual
f4cab35 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: #15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@tisAliG @addaleax
test: remove test messages for assert.strictEqual
96dcb6f 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: nodejs/node#15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@tisAliG @targos
test: remove test messages for assert.strictEqual
65eca54 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: #15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@tisAliG @MylesBorins
test: remove test messages for assert.strictEqual
269b6d0 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: #15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tisAliG @MylesBorins
test: remove test messages for assert.strictEqual
e2b35b8 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: #15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tisAliG @MylesBorins
test: remove test messages for assert.strictEqual
57ae105 
Remove test messages for assert.strictEqual,
as the default messages are a better option.

PR-URL: #15995
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@joyeecheung joyeecheung joyeecheung approved these changes

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tisAliG @joyeecheung @jasnell @lpinca @hiroppy @BridgeAR @mscdex @MylesBorins @Trott @nodejs-github-bot