Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:modified crypto-binary test #15981

Closed
wants to merge 1 commit into from
Closed

test:modified crypto-binary test #15981

wants to merge 1 commit into from

Conversation

corvinrok
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10687/

@joyeecheung
Copy link
Member

Landed in 24d7294, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
@corvinrok @joyeecheung
test: remove error messages in crypto-binary test
24d7294 
PR-URL: #15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@corvinrok @addaleax
test: remove error messages in crypto-binary test
90b1b97 
PR-URL: nodejs/node#15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@corvinrok @targos
test: remove error messages in crypto-binary test
9e8df31 
PR-URL: #15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@corvinrok @MylesBorins
test: remove error messages in crypto-binary test
83311b8 
PR-URL: #15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@corvinrok @MylesBorins
test: remove error messages in crypto-binary test
17e0ab2 
PR-URL: #15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@corvinrok @MylesBorins
test: remove error messages in crypto-binary test
f46e118 
PR-URL: #15981
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@corvinrok @jasnell @joyeecheung @lpinca @cjihrig @mscdex @MylesBorins @Trott @nodejs-github-bot