Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace commom.fixturesDir with common.fixtures #15967

Closed
wants to merge 2 commits into from
Closed

test: replace commom.fixturesDir with common.fixtures #15967

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30f295
test: replace commom.fixturesDir with common.fixtures
kagbakpem Oct 6, 2017
8dd6945
test: update fixtures path in test-fs-read-stream-inherit.js
kagbakpem Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-fs-read-stream-inherit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ const assert = require('assert');
const fs = require('fs');
const path = require('path');

const fn = path.join(common.fixturesDir, 'elipses.txt');
const rangeFile = path.join(common.fixturesDir, 'x.txt');
const fn = path.join(common.fixtures, 'elipses.txt');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one would fail tests as common module does not export fixtures. Have a look at test/common/fixtures.js module and use fixtures.path.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the change here should be:

const fixtures = require('../common/fixtures');

then...

const fn = fixtures.path('elipses.txt');
const rangeFile = fixtures.path('x.txt');

const rangeFile = path.join(common.fixtures, 'x.txt');

{
let paused = false;
Expand Down