test: Replace common.fixturesDir with usage of the common.fixtures #15878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kysnm
force-pushed
the
test-htt2-respond-file-fd-range-fixtures
branch
2 times, most recently
from
b1ba07e to
7be148d
Compare
kysnm
force-pushed
the
test-htt2-respond-file-fd-range-fixtures
branch
from
7be148d to
64d3ca8
Compare
Trott
added
the
code-and-learn
cjihrig
approved these changes
Oct 7, 2017
benjamingr
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 10, 2017
| @@ -3,19 +3,19 @@ | |||
| // Tests the ability to minimally request a byte range with respondWithFD | |||
|
|
|||
| const common = require('../common'); | |||
| const fixtures = require('../common/fixtures'); | |||
There was a problem hiding this comment.
Nit: would you mind moving this after the common.hasCrypto check?
gireeshpunathil
approved these changes
Oct 12, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15878 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 9943cb2 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15878 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15878 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace common.fixturesDir with usage of the common.fixtures
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)