Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js #15822

Closed
wants to merge 1 commit into from
Closed

test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js #15822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/parallel/test-fs-symlink-dir-junction-relative.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,15 @@
// Test creating and resolving relative junction or symbolic link

const common = require('../common');
const fixtures = require('../common/fixtures');
const assert = require('assert');
const path = require('path');
const fs = require('fs');

const linkPath1 = path.join(common.tmpDir, 'junction1');
const linkPath2 = path.join(common.tmpDir, 'junction2');
const linkTarget = path.join(common.fixturesDir);
const linkData = path.join(common.fixturesDir);
const linkTarget = path.join(fixtures.fixturesDir);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this could just be changed to const linkTarget = fixtures.fixuresDir;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmg maybe this could be handled when it lands? See nodejs/code-and-learn#70 (comment). I know this isn't really a nit such as message line lengths, but I agree with @gibfahn that force pushes and amended commits are a bit of a high barrier for code-and-learn first time contributors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force pushing isn't required for this, @genewoo if you would be willing to make the change @rmg suggested that would be great, you can change the line and push another commit to your branch.

Agreed that this isn't a blocker (which I assume is why @rmg didn't request changes).

const linkData = path.join(fixtures.fixturesDir);

common.refreshTmpDir();

Expand Down