test: http2 session operations after destroy #15758
Conversation
trivikr
force-pushed
the
test-http2-server-destroy
branch
from
92210c1
to
0b978f5
Compare
trivikr
force-pushed
the
test-http2-server-destroy
branch
from
0b978f5
to
579ce40
Compare
|
Performed git rebase with upstream/master |
|
Ci will need to be re-run for this. It's not running any subtasks. |
trivikr
force-pushed
the
test-http2-server-destroy
branch
from
579ce40
to
3a0df5f
Compare
|
The CI is failing on slower platforms https://ci.nodejs.org/job/node-test-commit/13125//console |
| common.expectsError(() => session.settings(), invalidSessionError); | ||
| common.expectsError(() => session.shutdown(), invalidSessionError); | ||
| common.expectsError(() => session.rstStream(), invalidSessionError); | ||
| }, common.platformTimeout(100), stream.session); |
There was a problem hiding this comment.
As with the other PR, please undo this setTimeout() and common.platformTimeout() change unless you can demonstrate a need. In general, please don't make changes to tests because of unrelated failures in CI.
There was a problem hiding this comment.
Switched to setImmediate in the new commit
|
It looks like this deletes a test file. Is that a mistake? If not, can you explain? |
trivikr
force-pushed
the
test-http2-server-destroy
branch
from
3a0df5f
to
23d4933
Compare
|
@Trott The file |
Trott
dismissed
their stale review
common.platformTimeout() has been removed. Thanks!
Refs #14985 PR-URL: #15758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
|
Landed in abbdcaa |
Refs #14985 PR-URL: nodejs/node#15758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Refs #14985 PR-URL: #15758 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
This PR adds checks for invalid session errors for session operations when they're called after session.destroy() in HTTP2
Refs #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, http2