gitignore: ignore xcode workspaces and projects #1562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling ./configure --xcode creates xcode projects and a workspace for io.js.
|
Have also ran into this. +1 |
|
imo such files belong to your personal/global .gitignore file since they are not specific to a project |
|
that was just an imo, no need to close right away :P |
|
Sorry, was little bit toooo fast with some edits |
|
LGTM. We have Visual Studio stuff in already, so this makes sense |
|
An option on our build produces it. I think we should ignore it. |
|
I agree with @Fishrock123. Files generated by build or configure options should be ignored. LGTM. |
|
Agh, we should get consensus first. I'm +1 for adding it if we generate it. |
|
LGTM. |
|
LGTM as well. I think that's enough consensus? |
silverwind
pushed a commit
that referenced
this pull request
Apr 30, 2015
Calling ./configure --xcode creates xcode projects and a workspace for io.js. PR-URL: #1562 Reviewed-By: Vladimir Kurchatkin <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
|
Thanks! Landed in 801b47a |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Calling ./configure --xcode creates xcode projects and a workspace for io.js. PR-URL: nodejs#1562 Reviewed-By: Vladimir Kurchatkin <[email protected]> Reviewed-By: Chris Dickinson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling ./configure --xcode creates xcode projects and a workspace for io.js for each dep. This commit adds them to the git ignore like vs project files.