Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: fix warning about size_t compare with int #15508

Closed
wants to merge 4 commits into from

Commits on Sep 20, 2017

  1. n-api: fix warning about size_t compare with int

    Sampson Gao committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    657d660 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2017

  1. Define NAPI_AUTO_LENGTH for string length

    Sampson Gao committed Sep 21, 2017
    Configuration menu
    Copy the full SHA
    b1bf44a View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2017

  1. Use std::string for copying string

    Sampson Gao committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    a7ab686 View commit details
    Browse the repository at this point in the history
  2. squash: address latest comments

    Make checks directly against NAPI_AUTO_LENGTH
    Add assert
    Remove one check in unrelated napi function that was
    causing a warning and is not needed
    mhdawson committed Sep 22, 2017
    Configuration menu
    Copy the full SHA
    c4732e7 View commit details
    Browse the repository at this point in the history