Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed example in streams for write() after end() #155

Closed
wants to merge 1 commit into from
Closed

docs: changed example in streams for write() after end() #155

wants to merge 1 commit into from

Conversation

a0viedo
Copy link
Member

@a0viedo a0viedo commented Dec 12, 2014

Currently there's an example using http.ServerResponse stream, which
has a known bug and will not throw an error while writing after end().
Changed to a writable stream from fs which behaves as expected.

fixes nodejs/node-v0.x-archive#8814

Currently there's an example using http.ServerResponse stream, which
has a known bug and will not throw an error while writing after end().
Changed to a writable stream from fs which behaves as expected.

fixes nodejs/node-v0.x-archive#8814
@brendanashworth
Copy link
Contributor

👍 from me

bnoordhuis pushed a commit that referenced this pull request Dec 14, 2014
Currently there's an example using http.ServerResponse stream, which
has a known bug and will not throw an error while writing after end().
Changed to a writable stream from fs which behaves as expected.

Fixes nodejs/node-v0.x-archive#8814.

PR-URL: #155
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Brendan Ashworth <[email protected]>
@bnoordhuis
Copy link
Member

Cheers Alejandro, landed in 524882f with @brendanashworth as co-reviewer. Heads up, I had to tweak the commit log a little to make it conform to the style guide.

@bnoordhuis bnoordhuis closed this Dec 14, 2014
@a0viedo
Copy link
Member Author

a0viedo commented Dec 14, 2014

awesome! thanks @bnoordhuis and @brendanashworth

kunalspathak referenced this pull request in nodejs/node-chakracore Jan 22, 2016
If `--debug` is specified, the in-built 'Debug' object is exposed by
chakra.dll that has some [APIs](https://msdn.microsoft.com/en-us/library/bs12a9wf(v=vs.94).aspx) that node-uwp relies on. With my change in #155,
I had overriden 'Debug' global object and hence certain Debug APIs stopped
working with `--debug` switch. The original intent of adding `Debug` object
was that `util.js` fetches this object in Debugging context. In absense of
`--debug` flag this object is unavailable and hence `util.js` throws TypeError.

The fix is to expose `Debug` object only in the DebugContext (called from
`util.js`). If ran with `--debug`, by the time `utill.js` code executes, engine
would have already expose in-built `Debug` object and we won't overwrite it.
Without `--debug` we would override `Debug` object.

Thanks @agarwal-sandeep for helping debugging this issue.

Fixes : #175
boingoing pushed a commit to boingoing/node that referenced this pull request Apr 6, 2017
napi: add finalize hint support

Change napi_finalize_callback to support a hint parameter
APIs that take in a finalize callback now also take a hint
This hint is passed back in when the finalize callback is
called

Fixes: nodejs#111 
Reviewed-By: @jasongin @boingoing @mhdawson 
PR-Url: nodejs/abi-stable-node#155
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request Dec 5, 2023
…dejs#155)

The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request May 28, 2024
…dejs#155)

The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
syg pushed a commit to syg/node that referenced this pull request Jun 20, 2024
…dejs#155)

The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
# Conflicts:
#	test/parallel/parallel.status
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request Aug 28, 2024
…dejs#155)

The failing test is a regression test for nodejs#39717, which is about a crash that occurs when the flag is disabled. Given that that will no longer be possible once the flag is gone, this seems safe to disable forever.
# Conflicts:
#	test/parallel/parallel.status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants