-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove -J from test-ci and fix test-net-dns-custom-lookup #1544
Conversation
The rationale behind still using Anyway, LGTM. |
yes, for the record, we haven't actually been using |
parallel tests still not working on most build slaves PR-URL: nodejs#1544 Reviewed-By: Johan Bergström <[email protected]>
merged as 2a3c8c1, #1531 went in separately |
parallel tests still not working on most build slaves PR-URL: nodejs#1544 Reviewed-By: Johan Bergström <[email protected]>
parallel tests still not working on most build slaves PR-URL: nodejs#1544 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / 2a3c8c1 Reviewed-By: Johan Bergström <[email protected]>
This pulls in #1531 as well because it's the way to get passing builds on Jenkins when combined with removing
-J
from the test runner.Ideally we should be able to use
-J
but it's borked on most of the build slaves but it would be nice if we could have it working so they are quicker to run. Something for @indutny to chime in on perhaps, @jbergstroem has also been looking at it.Test run for these 2 commits: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/630/