Error alphabetization fixes #15307
Closed
Error alphabetization fixes #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
|
Was just looking at this too. I think, ideally, the doc at |
|
We should likely swap the order of these two commits to avoid having a commit with a broken test suite... this would break |
lpinca
approved these changes
Sep 10, 2017
hiroppy
approved these changes
Sep 10, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors.
Was not using proper magic comment syntax before!
maclover7
force-pushed
the
jm-lint-enable
branch
from
6bfcfaf
to
f3f2373
Compare
|
@MylesBorins swapped commit order |
cjihrig
approved these changes
Sep 10, 2017
tniessen
reviewed
Sep 11, 2017
| E('ERR_V8BREAKITERATOR', 'Full ICU data not installed. ' + | ||
| 'See https://github.com/nodejs/node/wiki/Intl'); | ||
| E('ERR_VALID_PERFORMANCE_ENTRY_TYPE', | ||
| 'At least one valid performance entry type is required'); | ||
| E('ERR_VALUE_OUT_OF_RANGE', 'The value of "%s" must be %s. Received "%s"'); | ||
| E('ERR_VALUE_OUT_OF_RANGE', (start, end, value) => { | ||
| return `The value of "${start}" must be ${end}. Received "${value}"`; |
There was a problem hiding this comment.
The variable names are misleading. The first parameter is the name of the value and the second is a description of the set of permitted values, so they don't actually depict a [start, end] range. Could you change the names while you are at it?
jasnell
approved these changes
Sep 12, 2017
|
@maclover7 this needs a rebase. |
|
Rebased on landing. |
jasnell
pushed a commit
that referenced
this pull request
Sep 14, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors. also properly enable lint rule Was not using proper magic comment syntax before! -URL: #15307 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in e9358af |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors. also properly enable lint rule Was not using proper magic comment syntax before! -URL: nodejs/node#15307 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
This would need to be backported for v8.x |
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors. also properly enable lint rule Was not using proper magic comment syntax before! -URL: nodejs/node#15307 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors. also properly enable lint rule Was not using proper magic comment syntax before! -URL: #15307 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
Also fixes error being (now!) properly thrown by alphabetize-errors. also properly enable lint rule Was not using proper magic comment syntax before! -URL: #15307 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things going on here:
alphabetize-errorslint rule (thank you @MylesBorins for pointing this out via Alphabatize errors lint rule does not appear to work #15305!)lib/internal/errors.js, by removing a duplicate error definition (two for one special, I guess!)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors, test