Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in LICENSE #15263

Closed
wants to merge 1 commit into from
Closed

Fixed a typo in LICENSE #15263

wants to merge 1 commit into from

Conversation

MKRhere
Copy link

@MKRhere MKRhere commented Sep 8, 2017

Line 134: "Copyrighy" instead of "Copyright".

Refer #15261

Line 134: "Copyrighy" instead of "Copyright".
@MKRhere MKRhere mentioned this pull request Sep 8, 2017
@Trott
Copy link
Member

Trott commented Sep 8, 2017

Hi @MKRhere! Welcome (again) and thanks (again)! Just repeating what I said in the PR for folks who end up here rather than there:

The typo is in a dependency and so that file will be overwritten the next time we update from the upstream source. The change request should go to the ICU project. You can see the typo in their source tree at http://source.icu-project.org/repos/icu/trunk/icu4c/LICENSE. Their guide on how to contribute to their project is at http://site.icu-project.org/processes/contribute. Hope this helps.

@MKRhere
Copy link
Author

MKRhere commented Sep 8, 2017

Thank you @Trott! I couldn't find a way to contribute without being a member, but I could add an ticket on their trac:

http://bugs.icu-project.org/trac/ticket/13350

I hope this will be solved and will reflect in Node too.
Thanks for the response!

@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Sep 8, 2017
@Trott
Copy link
Member

Trott commented Sep 8, 2017

Thank you @Trott! I couldn't find a way to contribute without being a member,

Maybe someone on @nodejs/intl knows what to do or is a member and can take care of it.

@Trott Trott closed this Sep 8, 2017
@srl295
Copy link
Member

srl295 commented Sep 13, 2017

@MKRhere ok sorry, i saw this go by but didn't see that it was in ICU. No, please do not change deps/small-icu, it is generated as mentioned. The file is actually not sourced from ICU but yet another embedded source. ICU will be making patch though, so in a future ICU this will be fixed. Thanks.
(repeating my comment)

@srl295
Copy link
Member

srl295 commented Sep 13, 2017

MKRhere you said:

Thank you @Trott! I couldn't find a way to contribute without being a member, but I could add an ticket on their trac:

OT but I'm curious what you mean. We have a how to contribute on the sidebar of icu-project.org i'm not sure what kind of member you were referring to?

I see @Trott already linked to this page. If there's a way we can improve it, please let me know! @

@MKRhere
Copy link
Author

MKRhere commented Sep 13, 2017

@srl295 I could clone the repository but not push to it. Either way, as long as the patch goes through, it's fine.

Note: this document is targeted to ICU Developers who have write permission on the ICU repository. If you are looking to simply access the ICU repository anonymously, see: Using the ICU Source Repository.)

This sounds to me like I need to be an ICU Developer and have an account before I can contribute any patches to their source. Anyway the change was trivial enough that any other member can take care of it!

@srl295 srl295 mentioned this pull request Sep 21, 2017
@srl295 srl295 mentioned this pull request Nov 8, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants