Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-benchmark-assert #15174

Closed
wants to merge 3 commits into from
Closed

test: add test-benchmark-assert #15174

wants to merge 3 commits into from

Commits on Sep 13, 2017

  1. benchmark: enable assert benchmark with short len 

    `deepequal-typedarrays.js` throws if `len` is set to 100 or less due to
a hardcoded index. Calculate the index based on `len` so benchmark can
be run with small `len` values if desired.
    @Trott
    Trott committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    5a2ce48 View commit details
    Browse the repository at this point in the history

  2. benchmark: provide default methods for assert 

    The benchmarks for `assert` all take a `method` configuration option,
but the allowable values are different across the files. For each
benchmark, provide an arbitrary default if `method` is set to an empty
string. This allows all the `assert` benchmarks to be run with a single
command but only on a single method. This is primarily useful for
testing that the assert benchmark files don't contain egregious errors.
(In other words, it's useful for testing.)
    @Trott
    Trott committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    9e3098c View commit details
    Browse the repository at this point in the history

  3. test: add test-benchmark-assert 

    Add minimal test for `assert` benchmarks.
    @Trott
    Trott committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    2405a3f View commit details
    Browse the repository at this point in the history