Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update http_parser to 2.5.0 #1517

Closed

Conversation

indutny
Copy link
Member

@indutny indutny commented Apr 24, 2015

@indutny
Copy link
Member Author

indutny commented Apr 24, 2015

@indutny
Copy link
Member Author

indutny commented Apr 24, 2015

Running benchmarks on the Digital Ocean server... (Makes me wonder if Digital Ocean could sponsor a server for benchmarks for us... :) )

@santigimeno
Copy link
Member

santigimeno commented Apr 24, 2015 via email

@indutny
Copy link
Member Author

indutny commented Apr 24, 2015

@santigimeno cat over the keyboard?

@mscdex
Copy link
Contributor

mscdex commented Apr 24, 2015

Maybe they are suggesting another test case input? ;-)

LGTM.

@santigimeno
Copy link
Member

@indutny sorry about that. My kid was playing with the phone

@indutny
Copy link
Member Author

indutny commented Apr 24, 2015

Benchmark results: https://gist.github.com/indutny/f4aef68005a0242a937e . Unfortunately, did it in reverse order so the - is actually a + and means that new parser is performing better.

Notable improvements:

  • http/end-vs-write-end.js type=asc kb=256 c=100 method=write: ./iojs-slow: 1588.6 ./iojs-fast: 1730.9 ........ -8.22%
  • http/_chunky_http_client.js len=8 num=5 type=send: ./iojs-slow: 120.86 ./iojs-fast: 161.31 ................. -25.08%

Otherwise appears to be ambivalent.

indutny added a commit that referenced this pull request Apr 24, 2015
PR-URL: #1517
Reviewed-By: Brian White <[email protected]>
@indutny
Copy link
Member Author

indutny commented Apr 24, 2015

Landed in b3a7da1, thank you!

@indutny indutny closed this Apr 24, 2015
@indutny indutny deleted the feature/update-http-parser-2.5.0 branch April 24, 2015 21:21
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 29, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 30, 2015
PR-URL: nodejs#1517
PORT-PR-URL: nodejs#1559
Reviewed-By: Brian White <[email protected]>
@rvagg rvagg mentioned this pull request May 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants