http2: correct emit error in onConnect, full tests #15080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. Refs: nodejs#14985
apapirovski
force-pushed
the
patch-http2-fix-and-test-request-on-connect
branch
from
45afbb7
to
89ea398
Compare
|
This change is ok. Can you remove I think it would be easier to debug in this way. |
|
It looks like right now only the event emits (in fact, looks like only the errors) are being run on nextTick, whereas a lot of the other stuff might be sync? So I guess I just wanted to confirm that we're ok with moving this up to where |
|
@apapirovski maybe not - what do you think @jasnell? |
jasnell
approved these changes
Sep 1, 2017
|
@mcollina ... I think I'm ok with this but would like your opinion on it as well. If you're not convinced we can talk it through and figure out what's better |
|
Landed in 8d5b013 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2017
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. PR-URL: #15080 Refs: #14985 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. PR-URL: nodejs/node#15080 Refs: nodejs/node#14985 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. PR-URL: #15080 Refs: #14985 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. PR-URL: #15080 Refs: #14985 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Correct requestOnConnect to emit session error on NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE rather than stream error. Add full test suite for the error handling within requestOnConnect. PR-URL: #15080 Refs: #14985 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor correction in
requestOnConnectto emit session error onNGHTTP2_ERR_STREAM_ID_NOT_AVAILABLErather than stream error. Mostly this is about adding a full test suite for the error handling within requestOnConnect.The test cases are a bit complicated as I felt like it was important to actually test all available errors, in case someone ever goes in and expands the switch statement to handle any other specific errors (or removes one of the currently handled ones). This way it avoids any accidental regressions where errors start emitting somewhere different than expected.
I also have a version of this for
pushStreamthat I'll adjust based on feedback here and then create a PR. (It's also emitting stream error onNGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE.)(I tried to find if there was any convention for mocking functions but it seemed like this is how it was done elsewhere.)
Let me know if there's anything I can adjust. Thanks!
Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test