Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2, async-wrap: introduce AliasedBuffer class #15077

Closed
wants to merge 4 commits into from
Closed

http2, async-wrap: introduce AliasedBuffer class #15077

wants to merge 4 commits into from

Commits on Sep 13, 2017

  1. http2, async-wrap: introduce AliasedBuffer class 

    This change introduces an AliasedBuffer class and updates asytnc-wrap
and http2 to use this class.

A common technique to optimize performance is to create a native buffer
and then map that native buffer to user space via JS array.  The runtime
can efficiently write to the native buffer without having to route
though JS, and the values being written are accessible from user space.

While efficient, this technique allows modifications to user
space memory w/out going through JS type system APIs, effectively
bypassing any monitoring the JS VM has in place to track program state
modifications.  The result is that monitors have an incorrect view
of prorgram state.

The AliasedBuffer class provides a future placeholder where this
technique can be used, but writes can still be observed.  To achieve
this, the node-chakra-core fork will add in appropriate tracking logic
in the AliasedBuffer's SetValue() method. Going forward, this class can
evolve to support more sophisticated mechanisms if necessary.
    Mike Kaufman authored and Mike Kaufman committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    96b39bb View commit details
    Browse the repository at this point in the history

  2. responding to PR feedback: cleaning up whitespace, snake-casing membe… 

    …r/variable names, adding const, some other stuff...
    Mike Kaufman committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    a47238b View commit details
    Browse the repository at this point in the history

  3. responding to PR feedback and fixing up whitespace/formatting

    Mike Kaufman committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    d06a833 View commit details
    Browse the repository at this point in the history

  4. respnoding to PR feedback

    Mike Kaufman committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    c6508f7 View commit details
    Browse the repository at this point in the history