Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't add libraries when --enable-static #14837

Closed
wants to merge 3 commits into from
Closed

build: don't add libraries when --enable-static #14837

wants to merge 3 commits into from

Commits on Aug 15, 2017

  1. build: don't add libraries when --enable-static 

    Currently when building with --enabled-static the cctest target will
include libraries to be linked regardless. This commit adds a condition
to only add the libraries when dynamically linking.

Fixes: nodejs#13500
    @danbev
    danbev committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    0a754e7 View commit details
    Browse the repository at this point in the history

  2. squash: move library files into variable

    @danbev
    danbev committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    78f076d View commit details
    Browse the repository at this point in the history

  3. [sqwsh] suggested workaround

    @refack
    refack authored Aug 15, 2017
    Configuration menu
    Copy the full SHA
    55f4887 View commit details
    Browse the repository at this point in the history