Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: revert 06cfff93, fixes overridden options #1467

Closed
wants to merge 4 commits into from
Closed

http: revert 06cfff93, fixes overridden options #1467

wants to merge 4 commits into from

Commits on Apr 18, 2015

  1. Revert "http: don't bother making a copy of the options" 

    This reverts commit 06cfff9.

Reverted because it introduced a regression where (because options were
modified in the later functionality) options.host and options.port would
be overridden with values provided in other, supported ways.
    @brendanashworth
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    cd7023c View commit details
    Browse the repository at this point in the history

  2. test: add test for 06cfff9 regression 

    This commit adds a test to ensure all options are NOT modified after
passing them to http.request. Specifically options.host and options.port
are the most prominent that would previously error, but add the other
options that have default values.

options.host and options.port were overridden for the one-argument
net.createConnection(options) call.
    @brendanashworth
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    8bccb49 View commit details
    Browse the repository at this point in the history

  3. !fixup fix test's localhost for FreeBSD runs

    @brendanashworth
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    ff88a4f View commit details
    Browse the repository at this point in the history

  4. !fixup more verbose test name

    @brendanashworth
    brendanashworth committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6e5cc0a View commit details
    Browse the repository at this point in the history