Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: add ability to remove a wrapping #14658

Closed
wants to merge 3 commits into from
Closed

n-api: add ability to remove a wrapping #14658

wants to merge 3 commits into from
+178 −25

Commits on Aug 17, 2017

  1. n-api: add ability to remove a wrapping 

    Calling napi_wrap() twice on the same object has the result of returning
napi_invalid_arg on the second call. However, sometimes it is necessary
to replace the native pointer associated with a given object. This new
API allows one to remove an existing pointer, returning the object to
its pristine, non-wrapped state.

Fixes: nodejs/abi-stable-node#266
    Gabriel Schulhof committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    0eb969b View commit details
    Browse the repository at this point in the history

  2. squash: update documentation and improve test 

    Mention that pointer ownership returns to the application after
napi_remove_wrap() and add test making sure the finalize callback gets
called when it needs to, and that it does not get called when it
shouldn't.
    Gabriel Schulhof committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    0f07c2f View commit details
    Browse the repository at this point in the history

  3. squash: fix linter issues

    Gabriel Schulhof committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    24126f4 View commit details
    Browse the repository at this point in the history