module: fix regression in require ../ #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is a regression, what was the commit that introduced it? Can you update the commit log to mention it? Thanks. |
Fixes regression in require system that prevented loading relative
packages via main property in package.json where the file is not
index.{ext}. The regression was introduced in
cfc1272.
evanlucas
force-pushed
the
require-regression
branch
from
73028eb
to
393b355
Compare
|
Ok, I have amended the commit log as well as the PR description. |
|
I was just about to dig into this after seeing it myself. From a quick look at the code, it looks like |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 11, 2014
Fixes regression in require system that prevented loading relative
packages via main property in package.json where the file is not
index.{ext}. The regression was introduced in commit cfc1272.
PR-URL: #145
Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Evan, landed in 87357b9 and good catch! |
|
For posterity, the commit that landed the original regression was 36777d2. |
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 11, 2014
Fixes regression in require system that prevented loading relative
packages via main property in package.json where the file is not
index.{ext}. The regression was introduced in commit 36777d2.
PR-URL: #145
Reviewed-By: Ben Noordhuis <[email protected]>
|
Oh, so it is. Amended in 78a7dc2. |
|
ah sorry about that |
boingoing
added a commit
to boingoing/node
that referenced
this pull request
Apr 6, 2017
…id_type napi: Buffer data argument should be void* instead of char*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression in require system that prevented loading relative
packages via main property in package.json where the file is not
index.{ext}. The regression was introduced via cfc1272
An example of a package affected by this is
node-gyp.