tls: fix empty issuer/subject/infoAccess parsing #14473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also issuerCertificate but that did not fit on the status line. Fixes: nodejs#11771
This was referenced Jul 25, 2017
refack
approved these changes
Jul 25, 2017
jasnell
approved these changes
Jul 25, 2017
mcollina
approved these changes
Jul 25, 2017
| if (c.subject) c.subject = tls.parseCertString(c.subject); | ||
| if (c.infoAccess) { | ||
| if (c.subject != null) c.subject = tls.parseCertString(c.subject); | ||
| if (c.infoAccess != null) { |
There was a problem hiding this comment.
can you put a quick comment that != null matches both null and undefined? I think that might not be newbie-friendly (also because in every guide about JS it is written to use ===).
There was a problem hiding this comment.
I'll add a comment if you insist but we use the x != null idiom all over the code base. It's not unique to this PR and we don't call it out explicitly anywhere else.
cjihrig
approved these changes
Jul 25, 2017
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Jul 27, 2017
Also issuerCertificate but that did not fit on the status line. Fixes: nodejs#11771 PR-URL: nodejs#14473 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
Also issuerCertificate but that did not fit on the status line. Fixes: #11771 PR-URL: #14473 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
|
Landed in 06a684a |
Merged
|
should this be backported to v6.x? |
|
Yes. |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
Also issuerCertificate but that did not fit on the status line. Fixes: #11771 PR-URL: #14473 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also issuerCertificate but that did not fit on the status line.
Fixes: #11771
Split off from #14447.
CI: https://ci.nodejs.org/job/node-test-pull-request/9342/