Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6.x backport 13531 docs #14413

Closed
wants to merge 1 commit into from
Closed

V6.x backport 13531 docs #14413

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Jul 21, 2017 •
edited
Loading

backport of docs from #13531

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. v6.x labels Jul 21, 2017
@sam-github
doc: document methods that return this
3dd5282 
Backport of the documentation from
nodejs#13531 that did not land in 2fb1381.

PR-URL: nodejs#13553
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@sam-github
Copy link
Contributor Author

@MylesBorins @nodejs/lts I'm not sure what the metadata should be. I left the metadata from the original PR in the commit, but that seems weird.

Have we agreed on a scheme for what metadata should look like on backport PRs?

@MylesBorins
Copy link
Contributor

@sam-github we agreed to keep all original meta data (including reviews) and add a new field backport-pr-url

@MylesBorins
Copy link
Contributor

I've gone ahead and rebased this back into the original cherry-pick 59eb761

@gibfahn gibfahn reopened this Jul 22, 2017
@gibfahn
Copy link
Member

gibfahn commented Jul 22, 2017

My bad @MylesBorins, didn't realise you meant you'd rebased and landed on v6.x-staging.

@gibfahn gibfahn closed this Jul 22, 2017
@sam-github sam-github deleted the v6.x-backport-13531-docs branch October 16, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-github @MylesBorins @gibfahn @refack @nodejs-github-bot