Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] deps: backport rehash strings after deserialization #14385

Closed
wants to merge 6 commits into from

Commits on Jul 18, 2017

  1. doc: document and test that methods return this

    Also, add tests to ensure they will always return this, and to confirm
    they return this when these doc changes are back-ported to earlier
    release lines.
    
    PR-URL: nodejs#13553
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    sam-github authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    2fb1381 View commit details
    Browse the repository at this point in the history
  2. test: mark test-fs-readdir-ucs2 flaky

    PR-URL: nodejs#13989
    Reviewed-By: Refael Ackermann <[email protected]>
    joaocgreis authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    dce4a75 View commit details
    Browse the repository at this point in the history
  3. test: mark test-npm-install flaky on arm

    PR-URL: nodejs#14035
    Refs: nodejs#14015
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    refack authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    448c8d4 View commit details
    Browse the repository at this point in the history
  4. build: run test-hash-seed at the end of test-v8

    The v8 and test-hash-seed targets cannot be run in parallel because they
    need different copies of the deps/v8 directory.
    
    Ref: nodejs#14004 (comment)
    PR-URL: nodejs#14219
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    targos authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    3b2c791 View commit details
    Browse the repository at this point in the history
  5. cluster, dns, repl, tls, util: fix RegExp nits

    * Take RegExp creation out of cycles.
    * Use test(), not match() in boolean context.
    * Remove redundant RegExp parts.
    
    Backport-PR-URL: nodejs#14348
    PR-URL: nodejs#13536
    Reviewed-By: Anna Henningsen <[email protected]>
    vsemozhetbyt authored and MylesBorins committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    ddc8050 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2017

  1. deps: backport rehash strings after deserialization

    Original commit messages:
    v8/v8@a2ab135
      [snapshot] Rehash strings after deserialization.
    
      See https://goo.gl/6aN8xA
    
      Bug: v8:6593
      Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9
      Reviewed-on: https://chromium-review.googlesource.com/574527
      Reviewed-by: Camillo Bruni <[email protected]>
      Reviewed-by: Jakob Gruber <[email protected]>
      Reviewed-by: Ulan Degenbaev <[email protected]>
      Commit-Queue: Yang Guo <[email protected]>
      Cr-Commit-Position: refs/heads/master@{nodejs#46732}
    
    v8/v8@182caaf
      Do not track transitions for built-in objects.
    
      Objects created during bootstrapping do not need
      a transition tree except for elements kind transitions.
    
      Bug: v8:6596
      Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182
      Reviewed-on: https://chromium-review.googlesource.com/571750
      Reviewed-by: Igor Sheludko <[email protected]>
      Commit-Queue: Yang Guo <[email protected]>
      Cr-Commit-Position: refs/heads/master@{nodejs#46693}
    
    Fixes: nodejs#14171
    PR-URL: nodejs#14385
    hashseed committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    adcab4d View commit details
    Browse the repository at this point in the history