Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JsConf Code & Learn]change the typeerror to a regular expression #14294

Closed
wants to merge 1 commit into from
Closed

[JsConf Code & Learn]change the typeerror to a regular expression #14294

wants to merge 1 commit into from

Conversation

bangwu
Copy link
Contributor

@bangwu bangwu commented Jul 16, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@bangwu bangwu changed the title change the typeerror to a regular expression [JsConf Code & Learn]change the typeerror to a regular expression Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@gibfahn
Copy link
Member

gibfahn commented Jul 16, 2017

Commit message needs a bit of fixup. Maybe:

test: change the TypeError to a regular expression

if you're not comfortable amending commits it can be done by whoever lands this.

Thanks for your contribution!

@tniessen tniessen self-assigned this Jul 16, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9179/

@Trott
Copy link
Member

Trott commented Jul 17, 2017

CI is green! 🎉

@Trott
Copy link
Member

Trott commented Jul 17, 2017

Duplicate of #14268. Closing.

@Trott Trott marked this as a duplicate of #14268 Jul 17, 2017
@Trott Trott closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees

@tniessen tniessen

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.