Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSConf CN Code&Learn]test: replace string concatenation with template literals #14278

Closed
wants to merge 1 commit into from
Closed

[JSConf CN Code&Learn]test: replace string concatenation with template literals #14278

wants to merge 1 commit into from

Conversation

jiangplus
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

no, just updated tests.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott
Trott requested changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be clearer if only line 35 was changed to a template literal and the rest was left as is.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@jiangplus
test: simplify string concatenation
9fa6785 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`
DavidCai1111
DavidCai1111 approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@DavidCai1111 DavidCai1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9155/ (by @DavidCai1993)

@Trott
Copy link
Member

Trott commented Jul 16, 2017

Green CI, trivial change, 9 Colalborator approvals, fast-tracking.

Landed in 32cb926

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 16, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
@jiangplus @Trott
test: simplify string concatenation
32cb926 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: nodejs#14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@jiangplus @addaleax
test: simplify string concatenation
802783d 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: #14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@jiangplus @Fishrock123
test: simplify string concatenation
36ef7e0 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: #14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@jiangplus @MylesBorins
test: simplify string concatenation
78efbd0 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: #14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@jiangplus @MylesBorins
test: simplify string concatenation
d462267 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: #14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@jiangplus @MylesBorins
test: simplify string concatenation
77506e4 
Replace string concatenation with template literals.
Updated `test/parallel/test-http-multi-line-headers.js`

PR-URL: #14278
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@Trott Trott Trott approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.