Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make node-gyp work with io.js-nightly versions #1424

Closed
wants to merge 2 commits into from

Conversation

jakeburden
Copy link

Check process.version for 'nightly'. If using io.js nightly, the disUrl is changed accordingly, allowing for the correct tarball url path to be created.

This allows node-gyp to work in io.js nightly versions.

@mscdex mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 14, 2015
@rvagg
Copy link
Member

rvagg commented Apr 14, 2015

we have next-nightly now too so this isn't quite right

I think I'm -1 on this for now since we really need to get the longer-term solution to node-gyp in there.

Some workarounds for this in the meantime are to:

  1. download the source and unpack it into the correctly named subdirectory in ~.node-gyp/
  2. have the source available either as an unpacked tar or the cloned repo and install/rebuild using npm and giving the flag --nodedir=/path/to/source
  3. same as 2 but bake it in to your npm config with npm config set nodedir=/path/to/source but this one's easier to forget if your source and io.js version get out of sync! Mostly it doesn't matter if they aren't perfectly in sync if you have the right branch (just next and v1.x currently) checked out so the ABI matches.

@piscisaureus
Copy link
Contributor

we really need to get the longer-term solution to node-gyp in there

Shipping the headers with the installer is something we should do also.
And indeed, I think we (as in io.js) should take control of node-gyp, and provide an end-to-end solution that doesn't only provide a build infrastructure but also the API (nan?) and possibly even the compiler itself.

@rvagg
Copy link
Member

rvagg commented Apr 16, 2015

@TooTallNate would you be interested in "donating" node-gyp to the iojs org like I've done with NAN? it would mean more eyes and hands on the code to improve it over time, including the long desired ability to use locally installed headers rather than download if they are available.

@Fishrock123
Copy link
Contributor

Closing in favor of #493

@jbergstroem
Copy link
Member

(closing for @Fishrock123, guessing he hit the wrong button)

@jbergstroem jbergstroem closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants