Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Supplement docs for Writable and Transform streams #142

Closed
wants to merge 1 commit into from

Conversation

vovacodes
Copy link
Contributor

Slightly fix and supplement the documentation for Writable#write and
Transform#transform methods. Make it more consistent. Mention
passing 'buffer' as an encoding param in case chunk is a Buffer.

Slightly fix and supplement the documentation for Writable#write and
Transform#transform methods. Make it more consistent. Mention
passing 'buffer' as an encoding param in case chunk is a Buffer.
@vovacodes
Copy link
Contributor Author

nodejs/node-v0.x-archive#8769 - the same changes for joyent/node

@rvagg
Copy link
Member

rvagg commented Jan 12, 2015

I'm down with this, LGTM so I'll merge, thanks @wizardzloy and sorry for the delay

@rvagg
Copy link
Member

rvagg commented Jan 12, 2015

nope, too far removed from the v1.x branch so it's too messy to pull this in. @wizardzloy could you please either rebase against the io.js/v1.x branch or re-submit these changes again from scratch?

piscisaureus pushed a commit that referenced this pull request Jan 12, 2015
Slightly fix and supplement the documentation for Writable#write and
Transform#transform methods. Make it more consistent. Mention passing
'buffer' as an encoding param in case chunk is a Buffer.

PR: #142
Reviewed-by: Bert Belder <[email protected]>
Reviewed-by: Rod Vagg <[email protected]>
@piscisaureus
Copy link
Contributor

lgtm & thanks. 68a2d8f

@rvagg
Copy link
Member

rvagg commented Jan 12, 2015

@piscisaureus how did you merge this? my git-fu is lacking and I couldn't get this to work cleanly enough to do quickly.

boingoing added a commit to boingoing/node that referenced this pull request Apr 6, 2017
napi: Remove napi_set_function_name since not all engines can rename functions
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request May 28, 2024
syg pushed a commit to syg/node that referenced this pull request Jun 20, 2024
eti-p-doray pushed a commit to eti-p-doray/node that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants