Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove redundant declaration #14199

Closed
wants to merge 1 commit into from
Closed

util: remove redundant declaration #14199

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jul 12, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util

This module is already required in the top scope (Line 3). So if I do not miss any intended side effects this declaration can be deleted.

@vsemozhetbyt
util: remove redundant declaration
489282f 
This module is already required in the top scope (Line 3).
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Jul 12, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Jul 12, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/9097/
Another try: https://ci.nodejs.org/job/node-test-pull-request/9104/
CI 3: https://ci.nodejs.org/job/node-test-pull-request/9111/

Trott
Trott approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@vsemozhetbyt
Copy link
Contributor Author

@Trott Can we consider CI fails unrelated?

@refack
Copy link
Contributor

refack commented Jul 14, 2017

This one (only fail in last run) https://ci.nodejs.org/job/node-test-commit-plinux/10191/nodes=ppcbe-ubuntu1404/ is unrelated #14206

@vsemozhetbyt
Copy link
Contributor Author

Landed in 2288e3f

@vsemozhetbyt vsemozhetbyt deleted the util.js-err branch July 14, 2017 22:14
vsemozhetbyt added a commit that referenced this pull request Jul 14, 2017
@vsemozhetbyt
util: remove redundant declaration
2288e3f 
This module is already required in the top scope (Line 3).

PR-URL: #14199
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@vsemozhetbyt @addaleax
util: remove redundant declaration
a675c3d 
This module is already required in the top scope (Line 3).

PR-URL: #14199
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@vsemozhetbyt @Fishrock123
util: remove redundant declaration
8490176 
This module is already required in the top scope (Line 3).

PR-URL: #14199
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vsemozhetbyt @refack @jasnell @Trott @lpinca @TimothyGu @cjihrig @tniessen @MylesBorins @nodejs-github-bot