test: try to fix test-cli-node-options #14195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
added
flaky-test
|
/cc @nodejs/platform-arm @nodejs/testing @sam-github |
|
Anecdotal number from my local Windows machine: After PR ~4.72s |
richardlau
reviewed
Jul 12, 2017
| maxBuffer: 1000000000, | ||
| }; | ||
| exec(process.execPath, argv, opts, common.mustCall(function(err, stdout) { | ||
| const argv = ['-e', 'console.log("B")']; |
There was a problem hiding this comment.
If all we're doing with -e is console.log() perhaps consider using -p instead?
|
-p 5.17s, 5.16s, 5.11s (faster by 5% with p = 2.3E-05) |
refack
force-pushed
the
tweak-not-test-cli-node-options
branch
from
31efaf7
to
e87ba7e
Compare
|
https://ci.nodejs.org/job/node-test-binary-arm/9184/RUN_SUBSET=2,label=pi1-raspbian-wheezy/console https://ci.nodejs.org/job/node-test-binary-arm/9184/RUN_SUBSET=3,label=pi1-raspbian-wheezy/console |
irrelevant@nodejs/testing |
|
Needs a rebase |
refack
force-pushed
the
tweak-not-test-cli-node-options
branch
from
e87ba7e
to
b6bb016
Compare
|
This is mainly to avoid timing out, currently on ok 31 parallel/test-cli-node-options
---
duration_ms: 40.833
...(https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=1,label=pi1-raspbian-wheezy/9971) split files take: /cc @nodejs/testing |
* partitioning the subprocess groups * use `-e` instead of module * reduce maxBuffer PR-URL: nodejs#14195 Fixes: nodejs#14191 Reviewed-By: Rich Trott <[email protected]>
refack
force-pushed
the
tweak-not-test-cli-node-options
branch
from
b6bb016
to
86e7c61
Compare
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 5, 2017
* partitioning the subprocess groups * use `-e` instead of module * reduce maxBuffer PR-URL: nodejs/node#14195 Fixes: nodejs/node#14191 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
* partitioning the subprocess groups * use `-e` instead of module * reduce maxBuffer PR-URL: #14195 Fixes: #14191 Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 11, 2017
* partitioning the subprocess groups * use `-e` instead of module * reduce maxBuffer PR-URL: #14195 Fixes: #14191 Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
* partitioning the subprocess groups * use `-e` instead of module * reduce maxBuffer PR-URL: #14195 Fixes: #14191 Reviewed-By: Rich Trott <[email protected]>
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-einstead of moduleFixes: #14191
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test,process,cli